Skip to content

fix: failing pipeline - #1252

Merged
Nyholm merged 2 commits into
overblog:masterfrom
maxbaldanza:fix/dump-schema-test-specified-by
Nov 20, 2026
Merged

Nyholm merged 2 commits into
overblog:masterfrom
maxbaldanza:fix/dump-schema-test-specified-by

Conversation

@maxbaldanza

Copy link
Copy Markdown
Contributor

Newer webonyx/graphql-php versions add the @specifiedBy directive and the __Type.specifiedByURL field to introspection output. Strip them from both expected and actual JSON so the fixtures stay valid across versions.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets
License MIT

Max Baldanza and others added 2 commits November 10, 2026 10:19
Newer webonyx/graphql-php versions add the @specifiedBy directive and the
__Type.specifiedByURL field to introspection output. Strip them from both
expected and actual JSON so the fixtures stay valid across versions.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The bundle's config shape adds the "scalarType" key, so it cannot be
covariant with the parent's type. Suppress it as webonyx does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@maxbaldanza maxbaldanza changed the title fix: ignore specifiedBy schema entries in dump schema tests fix: failing pipeline Nov 10, 2026
@maxbaldanza

Copy link
Copy Markdown
Contributor Author

@Nyholm maybe you have a better suggestion on fixing the pipeline but hope you don't mind I used Claude to get a green pipeline as it was failing on master.

@Nyholm Nyholm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Looks good

@Nyholm
Nyholm merged commit 38ba709 into overblog:master Nov 20, 2026
31 checks passed
@maxbaldanza
maxbaldanza deleted the fix/dump-schema-test-specified-by branch November 20, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants